ui: correct match status for revoked matches

[chappjc]

Resolves #1769

[chappjc]

@martonp In toying with this issue, it looked like handleOrderNote was processing orders that didn't apply to the page, hence the acceleration button appearing. But when I added a if (note.id !== this.orderID) return to handleOrderNote other issues popped up.

[chappjc]

Oh, note.id is a note token, not the order ID. Last commit uses the CoreOrder id. I suspect that'll fix #1760

A related issue I noticed is that self revokes like:

[ERR] CORE: Our contract would expire in the past (2022-08-09 15:18:45 +0000 UTC). REVOKING!
[TRC] CORE: Revoked match 07f3b7f146f247de0414241dcf957e844887429d3c5547b6e27fc85efb2772ab (Taker) in status MakerSwapCast considered inactive.
[INF] CORE: Retiring inactive order 3e7a77531f4afdb470e90b43df901b4a0f76b7a17b8e37c2968dc2232ab82421 in status executed

get retired sometimes before the server revoke that triggers proper revoke handling. So if you try to look at these retired orders and matches they don't look revoked. When you restart dexc they seem to get reconciled again and they look proper.

Going to switch gears for now.

[chappjc]

Just observed this when testing Decrediton update for v0.5 (not including this PR), where the two redeem txids get written the same:

Having the order page open while a swap is settling where you are both sides highlights some of these issues. I think this one is also resolved by the order ID filter in this PR.

[JoeGruffins]

Also resolves #1760 for me.

[chappjc]

I don't know why this line would be conditional on bttn.

[buck54321]

Because we're omitting the element in the Go template instead of using class="d-hide". It's a silly way to do it.

[chappjc]

Oh, so page.status doesn't exist unless page.cancelBttn exists too?

[chappjc]

      <div class="order-datum">
        <div>[[[Status]]]</div>
        <div>
          <span id="status">{{$ord.StatusString}}</span>
          {{if $ord.Cancelable}}
            <span id="cancelBttn" class="ico-cross fs12 ms-1 pointer hoverbg" data-tooltip="cancel order"></span>
          {{end}

Looks like page.status would be there even if page.cancelBttn is not.

To be clear, I was calling out the line page.status.textContent = OrderUtil.statusString(order).

[buck54321]

I wasn't commenting on why setting the status string was inside of the bttn conditional. Not sure on that, tbh.

[chappjc]

Gotcha. I highlighted too many lines with the github comment. The page.status condition must have been an error.