Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: make txWaitExpiration configurable #1789

Merged
merged 2 commits into from Aug 24, 2022
Merged

server: make txWaitExpiration configurable #1789

merged 2 commits into from Aug 24, 2022

Conversation

ukane-philemon
Copy link
Contributor

This diff makes txWaitExpiration configurable. Closes #150.

@chappjc
Copy link
Member

chappjc commented Aug 16, 2022

The utility is not clear after all this time, but it indeed would close #150
Perhaps it's something that might be useful to tweak by the server operator.

chappjc
chappjc requested changes Aug 22, 2022
View reviewed changes
server/cmd/dcrdex/config.go Outdated Show resolved Hide resolved
server/dex/dex.go Show resolved Hide resolved
chappjc
chappjc reviewed Aug 22, 2022
View reviewed changes
dex/msgjson/types.go Outdated Show resolved Hide resolved
buck54321
buck54321 requested changes Aug 24, 2022
View reviewed changes
server/cmd/dcrdex/config.go Outdated Show resolved Hide resolved
chappjc
chappjc approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Please just merge that one log in Swapper and it's g2g.

server/swap/swap.go Outdated Show resolved Hide resolved
@chappjc chappjc added this to the 0.6/1.0 milestone Aug 24, 2022
@chappjc chappjc merged commit 0ad4a4d into decred:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buck54321 buck54321 buck54321 approved these changes

@chappjc chappjc chappjc approved these changes

@JoeGruffins JoeGruffins JoeGruffins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

swap: tx wait expiration should be configurable
4 participants
@ukane-philemon @chappjc @buck54321 @JoeGruffins