Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/webserver: translate on load #1826

Merged
merged 1 commit into from Aug 31, 2022

Conversation

chappjc
Copy link
Member

@chappjc chappjc commented Aug 27, 2022

This removes the localized_html folder.

The translated templates are created at runtime instead.

With a few minor changes the existing template-builder tool that is executed by go generate no longer writes, but is still used to ensure no fatal issues with the templates.

@chappjc chappjc marked this pull request as ready for review August 27, 2022 23:27
@chappjc chappjc requested a review from buck54321 August 30, 2022 00:57
@chappjc chappjc added this to the 0.6/1.0 milestone Aug 30, 2022
@chappjc chappjc mentioned this pull request Aug 30, 2022
Copy link
Member

@buck54321 buck54321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much better!

@chappjc chappjc merged commit feec471 into decred:master Aug 31, 2022
@chappjc chappjc deleted the translate-on-start branch August 31, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants