server: fail fast if txindex is not enabled for btc clones #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated to these changes, but if you send an rpc request to zcash while it is still doing the initial scan, the request hangs forever. |
chappjc
requested changes
Nov 29, 2022
- This ensures txindex is enabled by fetching information for a
coinbase transaction of a given block which is essential for
dex activities. It is fatal for btc clone markets if this is not
enabled.
ukane-philemon
force-pushed
the
stxindex
branch
from
1f15dc5
to
83c0d5b
Compare
Hmm, other btc clones return an error almost immediately. I think using a new |
chappjc
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures
txindexis enabled by fetching information for acoinbasetransaction of a given block which is essential for dex activities as it could be fatal forbtcclone markets if this is not enabled. Closes #1778Litecoin Core version v0.21.2.1 has
getindexinforpc command. Tested with bitcoin cash, dogecoin, litecoin and should work for zcash(my zec refuses to sync).PS: @JoeGruffins, I'd be glad if you can find time to test this with zcash.