DigiByte #1993

chappjc · 2022-12-10T03:17:00Z

Resolves #1992

Regnet cannot be mined too quickly. https://twitter.com/chappjc/status/1601403517151113216?t=-H0D1YgQvpu2kvk5rMi8MQ&s=1

I still need to verify serialization is unchanged.

https://digibyte.org/docs/integrationguide.pdf

dex/testing/dgb/harness.sh

chappjc · 2023-01-09T15:11:55Z

A couple remaining items I haven't gotten to:

tx and block deserialization tests
update simnet trade test tool
~~dcrdex server market config with a dgb pair~~

And test, of course.

JoeGruffins · 2023-01-19T11:22:46Z

In the last commit, are any of the images besides dgb.png used?

Should v7.17.2 be ok? Running on testnet not finding any blocks. Any tips?

chappjc · 2023-01-19T13:51:44Z

In the last commit, are any of the images besides dgb.png used?

No I'll rm the ones we don't like.

Should v7.17.2 be ok? Running on testnet not finding any blocks. Any tips?

https://github.com/DigiByte-Core/digibyte/releases/tag/v7.17.3

But there's a nasty bug that makes "Loading block index..." at startup take in excess of 24 hrs.
I have a patch branch here: DigiByte-Core/digibyte#102
Mainnet does not seem to have this issue for the reasons described in the PR desc.

The testnet seeders have been down. That's another thing I raised with their community. For now, you'll have to replace the following lines:

https://github.com/DigiByte-Core/digibyte/blob/5ac15f556e2150c2a23f2b4e45f32fda4de3f9b6/src/chainparams.cpp#L414-L415

without the "seed." prefix to the host name.

Some other possible nodes to add manually are 91.197.230.186, 24.101.88.154, 47.75.38.245, 199.47.64.33, 8.214.25.169
Also not a problem with mainnet.

JoeGruffins · 2023-01-20T05:22:38Z

The harness seems to to be working on simnet. Not sure about testnet...

It looks like the dcrdex harness needs for dgb to be added and a market for it.

chappjc · 2023-01-20T16:56:25Z

Squashed in a few fixes: https://github.com/decred/dcrdex/compare/c828cc98add27773b0304c681ed2fc20ff27cf19..60d7ac475299ec38acbb35d59a6cd72ab7f39ffa
Server starts, but haven't tested trades yet.

ycagel · 2023-03-06T18:01:33Z

Thanks for all the hard work! Do you have an ETA of when DigiByte may get integrated?

buck54321 · 2023-03-06T20:31:48Z

Things are looking good. We've added the remaining work to our next proposal and I anticipate we can finish things up within weeks. Getting a DigiByte market up and running is another hurdle. We're working on improving our market-making tools. The rudimentary tools being released in 0.6 (any day now) can help bootstrap a market, but provide few knobs for fine-tuned bot behavior. We'll keep at it and keep in touch.

ycagel · 2023-03-08T00:52:21Z

Thanks for the prompt reply @buck54321! I will work on getting the DigiByte community involved once DGB is live on the platform. I think there are quite a few people that are excited about Decred DEX. Cheers.

buck54321

I doubt it would work anyway, because of the segwit misalignment, but when trying to trade, I see dgb wallet has no network peers (check your network or firewall).

buck54321 · 2023-03-20T21:51:21Z

client/asset/dgb/dgb.go

+
+var (
+	fallbackFeeKey = "fallbackfee"
+	configOpts     = []*asset.ConfigOption{


Looks like btc.RPCConfigOpts and btc.CommonConfigOpts will work.

client/asset/dgb/dgb.go

client/webserver/site/src/img/coins/dgb2.png

chappjc · 2023-03-23T20:25:06Z

ycagel · 2023-03-24T20:34:38Z

Amazing stuff @chappjc @buck54321! Are those screenshots actual orders? Was the other code fixes what you discussed before?

Cheers.

chappjc · 2023-03-25T04:55:30Z

Amazing stuff @chappjc @buck54321! Are those screenshots actual orders?

We ran a few trades with this PR. Looks good so far.

We put up the PR in December as a quick initial feasibility check, but today the Decred stakeholders approved a broader initiative that included Digibyte integration, so it got moving again. https://proposals.decred.org/record/ca6b749

Was the other code fixes what you discussed before?

We're still targeting the released versions of Digibyte (v7.17.3), which doesn't include the regtest/simnet changes to make mining easier, like the easypow switch, but that will be valuable going forward. We haven't evaluated those changes yet, but we will.

It would also be good if the testnet issues were addressed, but we can work around it since it doesn't affect simnet or mainnet in practice.

I'll probably have some final questions before we release though. Stuff related to fee rates, dust limits, tx/block serialization, dandelion, etc. Will get back once more on the dex team have tested and reviewed.

chappjc · 2023-03-28T20:47:39Z

Fine on mainnet too

https://digiexplorer.info/tx/4da4eca50b54e67b3d2c5684938686b42385429fad6188b13e353bbad22aa877

chappjc · 2023-03-29T18:48:38Z

Rebased with #2196 merged, adding in AssetID: BipID, to the client clone config.

client/asset/dgb/dgb.go

client/core/simnet_trade.go

dex/testing/loadbot/loadbot.go

chappjc · 2023-03-31T15:54:52Z

simnet_trade tests OK, but you can't run them all at once because the digibyte node quickly becomes impossible to mine. You have to restart all the harnesses after each small test. For the same reason, loadbot isn't gonna be usable until the easypow change is released in v8 of digibyted.


*******************************************************************************

SUCCESS!! Test "makerghost" with client 1 as maker on market "dcr_dgb" PASSED!

*******************************************************************************

*******************************************************************************

SUCCESS!! Test "makerghost" with client 2 as maker on market "dcr_dgb" PASSED!

*******************************************************************************

chappjc · 2023-03-31T16:02:47Z

Squashed the fixups.

chappjc · 2023-04-11T00:22:11Z

Revalidated trades again today. Any lingering concerns?

buck54321 · 2023-04-11T00:26:35Z

I'll review this tomorrow. I'm sure it's g2g.

client/asset/btc/btc.go

ycagel · 2023-04-16T23:59:23Z

Thanks for all the hard work guys! How are things looking?

buck54321 · 2023-04-17T13:05:36Z

Work is merged. Didn't make it into 0.6.0, but we already have an 0.6.1 working for a (hopefully) quick follow-up and DigiByte will be in that release.

ycagel · 2023-05-02T16:22:40Z

Looks like there is more progress here guys! Awesome job and thank you!

ycagel · 2023-05-06T14:03:05Z

I see 0.6.1 was just released. Great work. Is DigiByte confirmed in that release?

buck54321 reviewed Jan 8, 2023

View reviewed changes

dex/testing/dgb/harness.sh Outdated Show resolved Hide resolved

buck54321 marked this pull request as ready for review January 9, 2023 06:18

chappjc added this to the 0.6.1 milestone Jan 11, 2023

chappjc mentioned this pull request Jan 16, 2023

server/asset: move CompatibilityCheck to dex/networks #2052

Merged

chappjc force-pushed the dbg branch 2 times, most recently from 1436d56 to 0c8b0f9 Compare January 16, 2023 15:15

chappjc force-pushed the dbg branch 2 times, most recently from c828cc9 to 60d7ac4 Compare January 20, 2023 16:47

chappjc mentioned this pull request Jan 21, 2023

docs: add guide to integrate new asset to readme #2061

Merged

buck54321 reviewed Mar 20, 2023

View reviewed changes

chappjc force-pushed the dbg branch 2 times, most recently from 5398837 to 2371603 Compare March 23, 2023 20:17

chappjc force-pushed the dbg branch from 2371603 to d908584 Compare March 23, 2023 20:44

chappjc force-pushed the dbg branch from d908584 to a003c41 Compare March 28, 2023 01:28

chappjc force-pushed the dbg branch from a003c41 to 5eb6d40 Compare March 29, 2023 18:46

chappjc modified the milestones: 0.6.1, 0.6 Mar 29, 2023

chappjc modified the milestones: 0.6, 0.6.1 Mar 30, 2023

chappjc force-pushed the dbg branch 3 times, most recently from 5e094eb to de60be0 Compare March 30, 2023 18:46

buck54321 requested changes Mar 30, 2023

View reviewed changes

client/asset/dgb/dgb.go Show resolved Hide resolved

client/core/simnet_trade.go Outdated Show resolved Hide resolved

dex/testing/loadbot/loadbot.go Outdated Show resolved Hide resolved

chappjc force-pushed the dbg branch from 0f19024 to fb1ae22 Compare March 31, 2023 16:02

chappjc force-pushed the dbg branch from fb1ae22 to ce62566 Compare April 10, 2023 23:07

buck54321 approved these changes Apr 13, 2023

View reviewed changes

client/asset/btc/btc.go Show resolved Hide resolved

chappjc added 9 commits April 14, 2023 11:54

dex/networks: add dgb params

4a7c844

server/asset: add dgb backend clone

fd82de4

client/asset: add dgb

7580187

client: simnet_trade_tests

177e062

dex/testing: dgb harness

24cd8bc

site: dgb explorer and icon

5485357

loadbot: add dgb

ed7e1f1

client/asset/btc: fix accel tx size computations

5cc5eb9

harness: variables for omega (gonode) ports

6211c13

chappjc force-pushed the dbg branch from ce62566 to 6211c13 Compare April 14, 2023 17:01

chappjc merged commit d68ae84 into decred:master Apr 14, 2023
5 checks passed

chappjc deleted the dbg branch April 14, 2023 17:25

chappjc mentioned this pull request Apr 25, 2023

[0.6.1] backports for release #2323

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DigiByte #1993

DigiByte #1993

chappjc commented Dec 10, 2022 •

edited

chappjc commented Jan 9, 2023 •

edited

JoeGruffins commented Jan 19, 2023 •

edited

chappjc commented Jan 19, 2023 •

edited

JoeGruffins commented Jan 20, 2023

chappjc commented Jan 20, 2023

ycagel commented Mar 6, 2023

buck54321 commented Mar 6, 2023

ycagel commented Mar 8, 2023

buck54321 left a comment

buck54321 Mar 20, 2023

chappjc commented Mar 23, 2023

ycagel commented Mar 24, 2023

chappjc commented Mar 25, 2023 •

edited

chappjc commented Mar 28, 2023

chappjc commented Mar 29, 2023

chappjc commented Mar 31, 2023 •

edited

chappjc commented Mar 31, 2023

chappjc commented Apr 11, 2023

buck54321 commented Apr 11, 2023

ycagel commented Apr 16, 2023

buck54321 commented Apr 17, 2023

ycagel commented May 2, 2023

ycagel commented May 6, 2023

DigiByte #1993

DigiByte #1993

Conversation

chappjc commented Dec 10, 2022 • edited

chappjc commented Jan 9, 2023 • edited

JoeGruffins commented Jan 19, 2023 • edited

chappjc commented Jan 19, 2023 • edited

JoeGruffins commented Jan 20, 2023

chappjc commented Jan 20, 2023

ycagel commented Mar 6, 2023

buck54321 commented Mar 6, 2023

ycagel commented Mar 8, 2023

buck54321 left a comment

Choose a reason for hiding this comment

buck54321 Mar 20, 2023

Choose a reason for hiding this comment

chappjc commented Mar 23, 2023

ycagel commented Mar 24, 2023

chappjc commented Mar 25, 2023 • edited

chappjc commented Mar 28, 2023

chappjc commented Mar 29, 2023

chappjc commented Mar 31, 2023 • edited

chappjc commented Mar 31, 2023

chappjc commented Apr 11, 2023

buck54321 commented Apr 11, 2023

ycagel commented Apr 16, 2023

buck54321 commented Apr 17, 2023

ycagel commented May 2, 2023

ycagel commented May 6, 2023

chappjc commented Dec 10, 2022 •

edited

chappjc commented Jan 9, 2023 •

edited

JoeGruffins commented Jan 19, 2023 •

edited

chappjc commented Jan 19, 2023 •

edited

chappjc commented Mar 25, 2023 •

edited

chappjc commented Mar 31, 2023 •

edited