client/asset/{btc,dcr}: maintain sync progress after losing peers #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
approved these changes
Dec 27, 2022
chappjc
reviewed
Dec 27, 2022
client/asset/dcr/spv.go
Outdated
Comment on lines
792
to
793
| // spv peers. This value is maintained even if the peer that reported the value | ||
| // later becomes disconnected. |
There was a problem hiding this comment.
I wonder if this is an attack vector. Is the spv syncer smart enough not to include peers with bogus chain heights?
There was a problem hiding this comment.
Probably not something we should rely on. Another thought I had, which now sounds more reasonable, is to only use the cached value if there are no more connected peers; otherwise the value reported by connected peers takes precedence. Will update.
JoeGruffins
approved these changes
Dec 29, 2022
itswisdomagain
force-pushed
the
sync-progress-peers
branch
from
373f44b
to
73816f5
Compare
chappjc
approved these changes
Dec 31, 2022
martonp
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2006.
Sync target height becomes 0 (for btc) or the same as the wallet tip (for dcr) when the correct value cannot be inferred from connected peers when the connection to all peers is lost.
Fix: cache sync target height so the cached value is used when calculating sync progress even when there are no peers connected.