client/asset: use compatible wallet dir and rework moveWalletData #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
approved these changes
Jan 3, 2023
buck54321
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2014
This reverts the BTC SPV wallet data directory so that there is no trailing
"spv"folder. This allows existing native BTC wallets created with 0.5 to be usable with 0.6, otherwise 0.6/master does not find them.This also reworks how the wallet backups are done so that all files in the native wallet directory are moved one at a time, skipping the "logs" folder so that the log rotator used by the package-level loggers is not interrupted. There is no longer an
"spvlogs"folder; it is back to the"logs"folder adjacent to the other neutrino and wallet db files.