eth: Always check header time. #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now sync status is always zero, so still not perfect. Not sure how to determine percent synced when talking to a geth node. The user can always look at their geth node however. Server is just wrong, Unix is already seconds. |
JoeGruffins
force-pushed
the
fixethsyncstatusagain
branch
2 times, most recently
from
1218aaa
to
7e5a022
Compare
JoeGruffins
changed the title
|
This page may have some insight into the process https://docs.ava.do/packages/geth/. There is probably a span during initial sync where the prog.CurrentBlock and prog.HighestBlock are different. After that, it looks like their dashboard will just say 99% until the headers are new. We could do that I suppose. |
|
I don't quite get why sync progress is useless after merge, but I agree that as longs as we don't say synced when it's not, that's what's important. Good catch on the server units. |
chappjc
reviewed
Jan 10, 2023
chappjc
approved these changes
Jan 10, 2023
JoeGruffins
force-pushed
the
fixethsyncstatusagain
branch
from
7e5a022
to
a417333
Compare
buck54321
approved these changes
Jan 11, 2023
Post merge geth will report both the current and highest block as the same number. Check the header time even when we would have been synced before the merge.
JoeGruffins
force-pushed
the
fixethsyncstatusagain
branch
from
a417333
to
d7dac1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post merge geth will report both the current and highest block as the same number. Check the header time even when we would have been synced before the merge.
closes #2017