client/db/bolt: ignore notes with bad IDs #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
commented
Feb 18, 2023
client/db/bolt/db.go
Outdated
| // and thus note ID did not include the TopicID. Ignore it. | ||
| db.log.Tracef("Ignoring stored note with bad key: %x != %x \"%s\"", | ||
| []byte(note.Id), trio.k, note.String()) | ||
| // trio.b.Put(ackKey, byteTrue) |
There was a problem hiding this comment.
We could even move it to a new bucket with the correct key, but these are 1-1.5 year old notifications and I kinda don't wanna bother.
There was a problem hiding this comment.
I'm good with auto-acking these.
There was a problem hiding this comment.
Acking. My two unacknowledgeable notes logged once, and are now gone after restart. I think this should be good for this fairly rare situation (upgraded with unacked notes, over a year ago).
There was a problem hiding this comment.
Also worth noting that these notes would fall off the latest 100 list eventually anyway, but that can take a while for light use.
There was a problem hiding this comment.
Auto-acking in last force push.
chappjc
force-pushed
the
misplaced-db-notes
branch
from
e48e3cd
to
39d57e1
Compare
JoeGruffins
approved these changes
Feb 20, 2023
buck54321
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The db.Notification serialization and thus ID changed in c994f03#diff-592072666205a423f50bc3061a74c2cda51bfe4689d4044315ff285d29645bc3R832
The ID was used as the bucket key.
Therefore any notes prior to the upgrade will be stored in a bucket with a different key than it's new ID. This isn't a big deal except that acknowledging such notes will fail for eternity.
In draft because I'm considering auto-acking such notes on load.