Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: build with eth code by default #2157

Merged
merged 1 commit into from Feb 23, 2023
Merged

Conversation

chappjc
Copy link
Member

@chappjc chappjc commented Feb 22, 2023

This negates the lgpl build tag, making it nolgpl.

The importlgpl.go files in the CLI app (main) packages are updated to indicate that the nolgpl build tag should be used to exclude such code if it is not acceptable.

Use of any of the eth-specific packages now implies lgpl. That is, we gate at the import of these packages in the cmd apps that would use them via their importlgpl.go files that require the !nolgpl build tag.

All docs and scripts are updated for the new default.

This negates the lgpl build tag, making it nolgpl.

The importlgpl.go files in the CLI app (main) packages are updated to
indicate that the `nolgpl` build tag should be used to exclude such
code if it is not acceptble.

Use eth-specific packages now implies lgpl. That is, we gate at the
import of these packages in the cmd apps that would use them via their
importlgpl.go files that require the !nolgpl build tag.

All docs and scripts are updated for the new default.
@chappjc
Copy link
Member Author

chappjc commented Feb 22, 2023

client/cmd/dexc:

$ go build -tags nolgpl && go version -m . | grep ethereum
$ go build && go version -m . | grep ethereum
	dep	github.com/ethereum/go-ethereum	v1.10.25	h1:5dFrKJDnYf8L6/5o42abCE6a9yJm9cs4EJVRyYMr55s=
$ 

@chappjc chappjc added this to the 0.6 milestone Feb 22, 2023
@chappjc chappjc marked this pull request as ready for review February 22, 2023 16:36
Copy link
Contributor

@martonp martonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't you putting!nolgpl in all the eth files? Was that just never needed?

@chappjc
Copy link
Member Author

chappjc commented Feb 22, 2023

Why aren't you putting!nolgpl in all the eth files?

Use of any of the eth-specific packages now implies lgpl. That is, we gate at the import of these packages in the cmd apps that would use them via their importlgpl.go files that require the !nolgpl build tag.

Seems reasonable since if you import the packages explicitly. There's a doc.go in each of those that basically states "by using this package use are using LGPL code"

But yeah, maybe this was all unneeded in the first place.

@chappjc
Copy link
Member Author

chappjc commented Feb 22, 2023

The other unfortunate thing I noticed is that if you use the gopkg.dev docs page (https://pkg.go.dev/decred.org/dcrdex), it does not even show the packages with no default-built code. I think it should show it all (with this PR), and the doc.go explains the license of that package.

@chappjc chappjc merged commit fb01d96 into decred:master Feb 23, 2023
@chappjc chappjc deleted the nolgpl branch February 23, 2023 19:08
@chappjc chappjc added the ETH label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants