Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variety of notifications from the client backend cause the frontend to update an asset's "button" on the wallet's page. In part, this involves setting
tmpl.img.src
, which unfortunately initiates a GET request for the resource, whether the path has changed or not.For instance, my testnet bch wallet was spewing wallet state notes, causing repeated fetches of the bch.png icon each time:
If the browser isn't sharp about caching these resources, it hits the backend repeatedly:
This PR updates the
updateAssetButton
method ofWalletsPage
so that it does not re-assign theimg.src
field if it has already been set. This method is called by at least 4 notification handlers, so it is the main offender.