client/core: Update token parent balances #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonp
changed the title
When an order involving a token was cancelled, the locked amount in the parent's balance would not be updated. Now, in `updateBalances`, when a token's balance is update is parents is also updated. This also moves the updates for the parent asset's balances from `sendTradeRequest` to `prepareTradeRequest`.
martonp
force-pushed
the
updateParentBalance
branch
from
63862c5
to
9073690
Compare
chappjc
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an order involving a token was cancelled, the locked amount in the parent's balance would not be updated. Now, in
updateBalances, when a token's balance is update is parents is also updated.This also moves the updates for the parent asset's balances from
sendTradeRequesttoprepareTradeRequest.