server/asset: trade address validation consistency #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trade address provided with an order is checked for validity, but it
also must be checked that it is the proper type for inclusion in a swap
contract. This renames server.asset.CheckAddress to CheckSwapAddress,
and updates it with the same type checks used client-side in
dex/networks/{dcr,btc}.MakeContract as well as in ExtractSwapDetails.
buck54321
approved these changes
Mar 23, 2023
JoeGruffins
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trade address provided with an order is checked for validity, but it also must be checked that it is the proper type for inclusion in a swap contract. This renames
server.asset.CheckAddresstoCheckSwapAddress, and updates it with the same type checks used client-side index/networks/{dcr,btc}.MakeContractas well as inExtractSwapDetails.