New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client/asset/eth: avoid confirmations overflow #2285

Merged

chappjc merged 1 commit into decred:master from norwnd:client-asset-eth-avoid-confirmations-overflow

Apr 4, 2023

Contributor

norwnd commented Apr 3, 2023

I think I observed this overflow recently on match card, consider additional protection when uints are used.


          client/asset/eth: avoid confirmations overflow

953a322

chappjc added this to the 0.6 milestone

chappjc approved these changes

View reviewed changes

Member

chappjc commented Apr 4, 2023

Potentially security issue if swapping too soon. Tested. Merging and including with 0.6

chappjc merged commit bf58d5b into decred:master

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment