dex/networks/ltc: witness limits fixes and decoder simplifications #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override the Read implementing io.Reader and make it do the mirroring. Any read will cause mirroring now automatically.
buck54321
approved these changes
Apr 19, 2023
They're still just throwing a way the MW tx haha, but yup, very cool
Thanks for testing it so thoroughly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ltcsuite is adopting our MW tx deserialization code, and it revealed a small usability issue with the
decoderAPI, which this fixes.This also updates the
maxWitnessItemsPerInputandmaxWitnessItemSizeto match the current values following the btcsuite backports in ltcsuite/ltcd#25