server/market: startup balance checks must convert base to quote #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an account-based asset is the quote asset in a market, and there is a booked buy order, the quantity to check must be in units of the quote asset (the account-based asset).
buck54321
approved these changes
Apr 19, 2023
|
Was able to repro and confirm that this is resolves the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an account-based asset is the quote asset in a market, and there is a booked buy order, the quantity to check must be in units of the quote asset (the account-based asset).
Test/repro: On the simnet harness fund your wallet with something like
0.39ETH. On the DCR-ETH market, book a buy order at 0.01 ETH/DCR for 1 lot, which should say "Total: 0.10 ETH".Stop the server process and start again with
./run. It would unbook the order because it was comparing the base asset (10 DCR or 1000000000 atoms) with the eth balance of 0.039 ETH (390000000 gwei).With this change, it will compare quote units (plus fees) against balance.