client/asset/dcr: refactor findRedemptionsInBlockRange to use cfilters #954
Conversation
itswisdomagain
force-pushed
the
dcr-findredemption-with-cfilters
branch
2 times, most recently
from
97e9ac7
to
7086e25
Compare
| } | ||
|
|
||
| // Pull the block info to confirm if any of its inputs spends a contract of interest. | ||
| blk, err := dcr.node.GetBlockVerbose(dcr.ctx, blockHash, true) |
There was a problem hiding this comment.
This is fine, but just a note: we don't really need getblock with either verbose=true or verboseTx=true since with a block's bytes we could deserialize and work on the MsgTxs. No changes requested though. It's going to be a headache to change, esp. on account of the helper methods needing TxRawResults. Besides this is not a hot path in dex client code.
There was a problem hiding this comment.
Will add a todo to that effect.
itswisdomagain
force-pushed
the
dcr-findredemption-with-cfilters
branch
from
7086e25
to
8f7a617
Compare
|
dcr, btc simnet tests and TestMakerGhostingAfterTakerRedeem passing |
| @@ -2048,6 +2084,33 @@ func (dcr *ExchangeWallet) fatalFindRedemptionsError(err error, contractOutpoint | |||
| dcr.findRedemptionMtx.Unlock() | |||
| } | |||
|
|
|||
| // blockMaybeContainsScripts uses the cfilters of the specified block to | |||
| // determine if the block likely includes any of the passed scripts. | |||
| func (dcr *ExchangeWallet) blockMaybeContainsScripts(blockHash string, scripts [][]byte) (bool, error) { | |||
There was a problem hiding this comment.
Let's remember to refactor this method in terms of the blockFilter struct and the getBlockFilterV2 methods slated to be added in #788
There was a problem hiding this comment.
Yeah, this will likely go in favor of that. Wanted a simple version in first. Or rather, this will use the new methods and struct.
Yeah. I want to revisit that today. |
This changes the client's DCR backend to use v2 cfilters to locate counterparty contract redemptions in blocks instead of always pulling blocks to check. This also adds a test for the mempool redemption search.
It is necessary to crawl backwards from the previous main chain tip to a main chain block (confs>0), the ancestor, to determine reorg depth. This logic is used to trigger findRedemptionsInBlockRange.
chappjc
force-pushed
the
dcr-findredemption-with-cfilters
branch
from
3333748
to
53697ed
Compare
Also
TestFindRedemptionto test finding redeem txs in mempool