multi: Add Ethereum server asset. #979

JoeGruffins · 2021-02-18T06:29:00Z

Work towards #939
Depends upon #956 and #944

Adds a skeleton eth server client.

JoeGruffins · 2021-03-02T08:37:21Z

dex/testing/eth/create-node.sh

 $CHAIN_PASSWORD
-$ADDRESS_PASSWORD


It does not appear that this was unlocking the account. We will pass the password when sending funds.

JoeGruffins · 2021-03-05T09:28:24Z

server/asset/eth/eth.go

+// decodeCoinID decodes the coin ID into a contract address and secret hash.
+func decodeCoinID(coinID []byte) (common.Address, []byte, error) {
+	if len(coinID) != coinIDSize {
+		return common.Address{}, nil, fmt.Errorf("coin ID wrong length. expected %d, got %d",
+			coinIDSize, len(coinID))
+	}
+	secretHash := make([]byte, 32)
+	copy(secretHash, coinID[20:])
+	return common.BytesToAddress(coinID[:20]), secretHash, nil
+}


I believe a "coin" is best identified by the address of the contract it belongs to and the secret hash it is keyed by. This is tentative and up for debate. See #1001
All info about the eth side of a swap will be accessed through the contract.

Wouldn't the eth contract address be a constant?

yes. If we update the contract, though, I assume it would change over time.

I think you're right.

I'm hesitant because it's hard to change a coin ID encoding once it's used on mainnet (unless we add a version byte?). I would hope that the contract would not change, even to the point that different servers would use the same contract by default. But in actuality, we might need to change it someday, and if we didn't encode it, we wouldn't necessarily have the information we need from the coin ID.

I'm not sure I follow that last part of that. There would not be any need to change a coin ID. Client would initiate the swap with a contract. Server will have a map of contract addresses and reject older contracts if necessary with a penalty. It makes perfect sense that all servers will be using the same contract. I don't think that is a problem.

I believe contracts will need to be updated for security reasons, and if eth consensus rules change.

There would not be any need to change a coin ID

Sorry. Not an individual coin ID. The coin ID encoding protocol. It's hard to change it later.

I think I will add a byte for flags. At least we might want unique ids for maker and taker, otherwise they would be the same. If there's somewhere using coin ids as a map key, expecting them to be unique... A one bit flag in the byte field could resolve this, and store a limited amount of arbitrary data in the future. maybe make it two bytes?

Added flags anyway. The scheme may be different in the end, as long as we decide on something before allowing mainnet. It may seem like this doesn't allow direct payments for a fee, but, a contract may be the best way to handle a fee payment. We could also have a flag that designates this is a transaction hash, then the "secret hash" could instead be the txid in that case.

I was wondering about normal transactions too, such as withdraw/deposit and how those would be encoded. I suspect we will need some kind of dynamic encoding with the flags to switch it to tx hash as you suggested. I'm just catching up on your eth work though so take that with a grain of salt.

Thinking through the coin ID issue: #1021

dex/testing/eth/harness.sh

buck54321

This is a great start to the server-side work. Having this skeleton in place will help us to visualize and compartmentalize the work for efficient development.

After the create-node.sh fix, this tests well. This will all be iterated over as we get deeper into implementation, so I think we can get this in soon.

@chappjc, any interest in maintaining a separate eth integration branch?

dex/testing/eth/create-node.sh

buck54321 · 2021-03-10T15:50:05Z

server/asset/eth/eth.go

+// decodeCoinID decodes the coin ID into a contract address and secret hash.
+func decodeCoinID(coinID []byte) (common.Address, []byte, error) {
+	if len(coinID) != coinIDSize {
+		return common.Address{}, nil, fmt.Errorf("coin ID wrong length. expected %d, got %d",
+			coinIDSize, len(coinID))
+	}
+	secretHash := make([]byte, 32)
+	copy(secretHash, coinID[20:])
+	return common.BytesToAddress(coinID[:20]), secretHash, nil
+}


I think you're right.

I'm hesitant because it's hard to change a coin ID encoding once it's used on mainnet (unless we add a version byte?). I would hope that the contract would not change, even to the point that different servers would use the same contract by default. But in actuality, we might need to change it someday, and if we didn't encode it, we wouldn't necessarily have the information we need from the coin ID.

dex/testing/eth/create-node.sh

server/asset/eth/client_harness_test.go

chappjc · 2021-03-10T16:38:19Z

@chappjc, any interest in maintaining a separate eth integration branch?

We can if it seems like eth work has the potential to break other things, but I don't mind having incomplete features on master if everything else is functional.

chappjc

Good to go with a go.sum resolve please (although either wisdom or yourself will have to resolve twice depending on who goes first).

I'm pretty confident we will have to evolve the coin ID encoding for ethereum, sometimes holding transactions and sometimes accounts and other data like secret hash as you have here, but we can definitely go forward with this.

Switch full nodes to fast nodes, which is most likely what servers will run, and add two light nodes, which is most likely what clients will run.

Adds a skeleton eth server client. The client connects over ipc and relays new blocks to the server.

JoeGruffins force-pushed the dexethserverclient branch 2 times, most recently from 451bd67 to 515979d Compare February 18, 2021 06:38

JoeGruffins force-pushed the dexethserverclient branch 2 times, most recently from 0c433e8 to 666c83a Compare March 2, 2021 08:32

JoeGruffins commented Mar 2, 2021

View reviewed changes

JoeGruffins force-pushed the dexethserverclient branch from 666c83a to 963f81a Compare March 5, 2021 09:24

JoeGruffins commented Mar 5, 2021

View reviewed changes

JoeGruffins marked this pull request as ready for review March 5, 2021 09:33

JoeGruffins force-pushed the dexethserverclient branch from 963f81a to e725834 Compare March 8, 2021 09:04

JoeGruffins commented Mar 9, 2021

View reviewed changes

dex/testing/eth/harness.sh Outdated Show resolved Hide resolved

buck54321 requested changes Mar 10, 2021

View reviewed changes

JoeGruffins force-pushed the dexethserverclient branch 2 times, most recently from 8c3b2ba to d451fac Compare March 11, 2021 04:43

chappjc mentioned this pull request Mar 22, 2021

eth: coin ID uses and encodings (discussion) #1021

Closed

chappjc added this to the 0.3 milestone Apr 7, 2021

JoeGruffins force-pushed the dexethserverclient branch from 1b435a8 to c8288aa Compare April 8, 2021 01:36

JoeGruffins force-pushed the dexethserverclient branch from c8288aa to 3912b63 Compare April 27, 2021 08:26

chappjc approved these changes Apr 30, 2021

View reviewed changes

dex/test/eth: Add light wallets.

c8040f6

Switch full nodes to fast nodes, which is most likely what servers will run, and add two light nodes, which is most likely what clients will run.

JoeGruffins force-pushed the dexethserverclient branch from 3912b63 to f2beea6 Compare May 1, 2021 00:18

JoeGruffins added 7 commits May 1, 2021 09:18

multi: Add Ethereum server asset.

edb7610

Adds a skeleton eth server client. The client connects over ipc and relays new blocks to the server.

Add not implemented error.

7a3e7c7

Rename client to rpcclient.

f7a1668

Unexport interface methods.

757fe27

Uncapitalize doc strings.

42a00de

Add flags to coinID.

b4de9b5

Satisfy asset.Driver interface.

f2beea6

chappjc merged commit 49dc413 into decred:master May 2, 2021

chappjc added the ETH label Jul 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

multi: Add Ethereum server asset. #979

multi: Add Ethereum server asset. #979

JoeGruffins commented Feb 18, 2021

JoeGruffins Mar 2, 2021

JoeGruffins Mar 5, 2021 •

edited

buck54321 Mar 5, 2021

JoeGruffins Mar 5, 2021 •

edited

buck54321 Mar 10, 2021

JoeGruffins Mar 11, 2021

buck54321 Mar 11, 2021

JoeGruffins Mar 11, 2021

JoeGruffins Mar 15, 2021 •

edited

chappjc Mar 15, 2021

chappjc Mar 22, 2021

buck54321 left a comment

buck54321 Mar 10, 2021

chappjc commented Mar 10, 2021

chappjc left a comment •

edited

		$CHAIN_PASSWORD
		$ADDRESS_PASSWORD

multi: Add Ethereum server asset. #979

multi: Add Ethereum server asset. #979

Conversation

JoeGruffins commented Feb 18, 2021

Choose a reason for hiding this comment

JoeGruffins Mar 5, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins Mar 5, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins Mar 15, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buck54321 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chappjc commented Mar 10, 2021

chappjc left a comment • edited

Choose a reason for hiding this comment

JoeGruffins Mar 5, 2021 •

edited

JoeGruffins Mar 5, 2021 •

edited

JoeGruffins Mar 15, 2021 •

edited

chappjc left a comment •

edited