Multi: Update dcrd and dcrwallet dependencies #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
force-pushed
the
update-dcrw-mod
branch
from
517592d
to
612b079
Compare
jrick
reviewed
Aug 5, 2021
matheusd
force-pushed
the
update-dcrw-mod
branch
from
6584ad2
to
dd8e76d
Compare
matheusd
commented
Aug 6, 2021
This updates the dependencies of dcrd and dcrwallet modules to their latest version. Note that most modules that have had a major version bump are still under development at this time and haven't had a final version tagged yet.
matheusd
force-pushed
the
update-dcrw-mod
branch
from
dd8e76d
to
15cdd0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the dcrwallet and dcrd dependencies to their current (in-development) version.
Due to the strong interdependency between the various packages, it's not really possible to do partial migrations that still work and pass all tests: all packages need to be updated in pretty much one go.
The most significant change is the introduction of the
stdaddrpackage in dcrd, which replaces uses ofdcrutil.Addressthroughout the codebases.Another change included in this PR is building and using a uniquely named
dcrdbinary for unit and integration tests (dcrd-dcrlnd) now that the upstream dcrd rpctest package supports specifying the dcrd binary to use. This avoids having to have the local dcrd binary replaced by a potentially in-development version when running the dcrlnd tests.