New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: use getTransaction grpc for confirmCoinbases. #334
Conversation
0d1f21f
to
0a1c123
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments, mostly for myself to remember I need to re-review some of the points later.
The reason we originally used TxConfNotifications
to track when coinbases become spendable was because of a race condition explained here in #222.
The old confirmCoinbases
blocked until all of the coinbases were spendable. I don't think the new one is blocked, so it seems like it will be prone to the same race condition.
I don't think the issue described in #222 is going to be a problem here since |
0a1c123
to
df8f0c3
Compare
Understood. Will deploy onto my test site and monitor for a few days. |
df8f0c3
to
62a6dd9
Compare
This reworks coinbase confirmation function to uses the getTransaction grpc to fetch transaction details and confirm them. The rescan begin height is now a coinbase maturity length of blocks from the lowest reported block with a tx having inaccurate confirmation information. Tests have been updated.
8240553
to
a8a6a74
Compare
This reworks coinbase confirmation function to uses the getTransaction grpc to fetch transaction details and confirm them. The rescan begin height is now a coinbase maturity length of blocks from the lowest reported block with a tx having inaccurate confirmation information. Tests have been updated.