rpc: implement getcfilterv2 and getblock JSON-RPC methods #1978
Conversation
| Size: int32(blk.Header.Size), | ||
| Bits: strconv.FormatInt(int64(blockHeader.Bits), 16), | ||
| SBits: sbitsFloat, | ||
| Difficulty: difficultyRatio(blockHeader.Bits, w.ChainParams()), |
There was a problem hiding this comment.
It looks like dcrwallet's difficultyRatio differs from dcrd's. dcrd does this additional intermediate step.
outString := difficulty.FloatString(8)
diff, err := strconv.ParseFloat(outString, 64)
And indeed, when I compare the getblock output, I see "difficulty": 1.66277624 for dcrd and "difficulty": 1.6627762413416893 for dcrwallet.
Maybe it doesn't really matter. I don't know.
There was a problem hiding this comment.
Yeah... I noticed that. I did not compare the outputs but the code difference looked like a simple case of output formatting. dcrd rounds to 8 decimal places using difficulty.FloatString(8) before converting the resulting value to a float64; while dcrwallet converts directly to float64 using difficulty.Float64().
I don't suppose there's an implication to not rounding first, but let me ping @davecgh to confirm.
There was a problem hiding this comment.
Thanks for giving this a look!
There was a problem hiding this comment.
It probably doesn't really matter since nothing should be using that value in any calculations as it's really there to provide a more human-readable value.
That said, the result should not be more than 8 decimal places long for at least a couple of reasons:
- It represents a ratio of a process that involves 256 bits and log_2(256) = 8
- It really should match what dcrd does anyway so you don't get different results
|
Aside from the conflicts on this PR and #1903, how are they looking? |
itswisdomagain
force-pushed
the
cfilters-rawblocks
branch
from
2993ee1
to
7e108c1
Compare
All good. Ready for review and merging. |
itswisdomagain
force-pushed
the
cfilters-rawblocks
branch
from
7e108c1
to
dcb0408
Compare
internal/rpc/jsonrpc/methods.go
Outdated
| blkBytes, err := blk.Bytes() | ||
| if err != nil { | ||
| return nil, rpcErrorf(dcrjson.ErrRPCInternal.Code, "Could not serialize block: %v", err) | ||
| } | ||
| return hex.EncodeToString(blkBytes), nil |
There was a problem hiding this comment.
let's avoid calling Bytes. this should instead use a hex.Encoder. there are some other examples of this technique in this file but this is the gist:
b := new(strings.Builder)
b.Grow(2 * blk.SerializeSize())
err = blk.Serialize(hex.NewEncoder(b))
return b.String(), nil
internal/rpc/jsonrpc/methods.go
Outdated
| } | ||
| nextHashString = nextBlockInfo.Hash.String() | ||
| } | ||
| confirmations = 1 + int64(bestHeight) - int64(blockHeader.Height) |
There was a problem hiding this comment.
use the confirms function to calculate this.
internal/rpc/jsonrpc/methods.go
Outdated
|
|
||
| // When the verbose flag isn't set, simply return the | ||
| // network-serialized block as a hex-encoded string. | ||
| if cmd.Verbose != nil && !*cmd.Verbose { |
There was a problem hiding this comment.
if cmd.Verbose == nil || !*cmd.Verbose {
internal/rpc/jsonrpc/methods.go
Outdated
| transactions := blk.Transactions | ||
| txNames := make([]string, len(transactions)) | ||
| for i, tx := range transactions { | ||
| txNames[i] = tx.CachedTxHash().String() |
There was a problem hiding this comment.
Use TxHash, not CachedTxHash (here and below).
internal/rpc/jsonrpc/methods.go
Outdated
| } | ||
|
|
||
| txReply := &dcrdtypes.TxRawResult{ | ||
| Hex: hex.EncodeToString(mtxBytes), |
There was a problem hiding this comment.
use the hex encoder to write to a strings.Builder like above.
| // The minimum difficulty is the max possible proof-of-work limit bits | ||
| // converted back to a number. Note this is not the same as the proof | ||
| // of work limit directly because the block difficulty is encoded in a | ||
| // block with the compact form which loses precision. | ||
| max := blockchain.CompactToBig(params.PowLimitBits) | ||
| target := blockchain.CompactToBig(bits) | ||
| ratio, _ := new(big.Rat).SetFrac(max, target).Float64() | ||
| return ratio | ||
|
|
||
| difficulty := new(big.Rat).SetFrac(max, target) | ||
| outString := difficulty.FloatString(8) | ||
| diff, err := strconv.ParseFloat(outString, 64) | ||
| if err != nil { | ||
| log.Errorf("Cannot get difficulty: %v", err) | ||
| return 0 | ||
| } | ||
| return diff |
There was a problem hiding this comment.
not clear why you are changing this.
There was a problem hiding this comment.
Primarily to mach dcrd's output; this change here mirrors dcrd's difficultyRatio. There was a conversation about it here.
Both methods closely resemble dcrd's implementations, with the exception of
the data returned by the
getcfilterv2method:json:"filter"instead ofjson:"data".keyrequired to query the returned filter formatches against committed scripts.