vspclient: More fixes for vsp fee confirmation tracking #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
reviewed
May 10, 2021
internal/vsp/feepayment.go
Outdated
| log.Errorf("cannot revoke vsp tickets %v", err) | ||
| } | ||
| } else { | ||
| log.Errorf("cannot revoke ticket since SPV mode") |
There was a problem hiding this comment.
we can remove this entirely or perhaps make it a debug log; this isn't an error.
jrick
reviewed
May 10, 2021
internal/vsp/feepayment.go
Outdated
Comment on lines
740
to
741
| if errors.As(err, &apiErr) { | ||
| if apiErr.Code == codeTicketCannotVote { |
There was a problem hiding this comment.
we can drop an indent by combining these if statements:
if errors.As(err, &apiErr) && apiErr.Code == codeTicketCannotVote
jrick
reviewed
May 10, 2021
internal/vsp/feepayment.go
Outdated
Comment on lines
896
to
897
| if errors.As(err, &apiErr) { | ||
| if apiErr.Code == codeFeeExpired { |
jrick
reviewed
May 10, 2021
internal/vsp/feepayment.go
Outdated
| log.Errorf("error abandoning expired fee tx %v", err) | ||
| } | ||
| fp.feeTx = nil | ||
| fp.submitPayment() |
There was a problem hiding this comment.
I don't like calling submitPayment from itself, since this perhaps has the possibility to recurse endlessly (and slowly because of the api call) until it eventually stack overflows. Can we just return an error and let the caller deal with it?
There was a problem hiding this comment.
clearing the fee tx is still correct though, but we should just let the caller deal with recreating and resubmitting it.
jrick
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the following fixes for vspClient tracking: