Bump the last watched indexes of HD accounts #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last watched indexes were never being increased except on the very first call to watchHDAddrs during the wallet sync. Because this index is used as the starting point for watching new addresses, the wallet would increasingly watch more and more of the same addresses each time, sending each of these in a series of 'loadtxfilter' calls to dcrd. This was bottlenecking block processing on long-running heavily-used wallets which create and watch many addresses (especially in the case of mixing ticketbuyers). There are still some duplicate addresses being watched, but this prevents the worst case situation of what is effectively a memory leak of data that gets sent over the network on every new derived address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last watched indexes were never being increased except on the very
first call to watchHDAddrs during the wallet sync. Because this index
is used as the starting point for watching new addresses, the wallet
would increasingly watch more and more of the same addresses each
time, sending each of these in a series of 'loadtxfilter' calls to
dcrd. This was bottlenecking block processing on long-running
heavily-used wallets which create and watch many addresses (especially
in the case of mixing ticketbuyers).
There are still some duplicate addresses being watched, but this
prevents the worst case situation of what is effectively a memory leak
of data that gets sent over the network on every new derived address.