rpc: Correct JSON-RPC and gRPC verifymessage. #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a test case on testnet: Before: After: |
alexlyp
reviewed
May 5, 2022
alexlyp
approved these changes
May 5, 2022
This corrects the main logic that verifies messages to create a p2pkh address from the recovered public key instead of a p2pk since p2pkh is what is produced when signing and therefore what is required when verifying (as can be verified in dcrd as well). This also updates the call sites that decode the addresses to properly reject p2pk addresses for the same reason.
davecgh
force-pushed
the
rpc_correct_verify_message
branch
from
f8e1e8a
to
a547182
Compare
jrick
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the main logic that verifies messages to create a p2pkh address from the recovered public key instead of a p2pk since p2pkh is what is produced when signing and therefore what is required when verifying (as can be verified in dcrd as well).
This also updates the call sites that decode the addresses to properly reject p2pk addresses for the same reason.