multi: Bump major version and update dcrd dependencies #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This increases the major version of the decred.org/dcrwallet module to version 3. This is needed to prepare for future changes which will be breaking changes from a semver point of view. All references to packages in the decred.org/dcrwallet/v2 module are changed to their respective v3 versions.
This commit updates the dcrd packages that have had a bump in their major version to their current (non-released) wip versions. The following modules/packages were updated: blockchain/stake => v4 to v5 blockchain => v4 to v5 gcs => v3 to v4 rpc/jsonrpc/types => v3 to v4 rpcclient => v7 to v8 The only significant change API-wise that affected dcrwallet was the removal of the extra arguments to stake.DetermineTxType and stake.IsRRTx/IsSSGen. The determination of whether to check for the additional rules pertaining to treasury and auto revocation agendas is done by the transaction version field of the transaction itself, so that eliminates the need for the additional flags. The official wallet software never produced transactions that did not follow this standard, therefore this is safe to do. The replace directives added to go.mod are needed due to the fact that some of the packages in dcrd (gcs/v4 and rpcclient/v8) depend on blockchain/stake/v5 and their own respective go.mod are set to require stake v5.0.0 (instead of a pre-release version).
Found via golangci-lint --enable=unused
|
this looks good at a first glance. i'll give it some more testing today. |
jrick
approved these changes
Nov 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the major version of the decred.org/dcrwallet module to version 3 and updates all dependencies of currently wip modules from dcrd to their corresponding major versions.
This is needed to keep the wallet master branch in sync with the current master dcrd.