Do not require additional newline prompting a hex seed #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently require an extra blank line following the seed during creation of a restored wallet. This is due to two factors: * During creation of a new wallet, we print the seed in PGP word list encoding using multiple lines, and users copy and paste this as is, newlines included. This means our prompt must support reading multiple lines of input. * Because the seed length is not required to be exactly 32 bytes (33 words), we don't know when to stop prompting for seed words that are split across multiple lines. An extra blank line after the seed is used to stop the prompting. This prompting behavior is only needed for seeds encoded with the PGP word list, and not seeds encoded in hex. If the first line of input is valid hex encoding, stop prompting immediately and do not require the additional blank line following the seed.
|
Code seems correct, but I'm fairly certain it will break existing automation like the various simnet creation scripts in dcrd, dcrdex, etc. |
|
I don't think so. The seed is always the final thing prompted for. Any input after it stops prompting earlier now will be discarded. I'm also not concerned with breaking |
|
Ah, I didn't know it would discard the extra input. That makes sense though and I agree it will be fine then. EDIT: Regarding expect, that will still probably have the same issue when providing the seed via words instead of the hex though. |
davecgh
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently require an extra blank line following the seed during creation of a restored wallet. This is due to two factors:
During creation of a new wallet, we print the seed in PGP word list encoding using multiple lines, and users copy and paste this as is, newlines included. This means our prompt must support reading multiple lines of input.
Because the seed length is not required to be exactly 32 bytes (33 words), we don't know when to stop prompting for seed words that are split across multiple lines. An extra blank line after the seed is used to stop the prompting.
This prompting behavior is only needed for seeds encoded with the PGP word list, and not seeds encoded in hex. If the first line of input is valid hex encoding, stop prompting immediately and do not require the additional blank line following the seed.