Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addrmgr module #2206

Merged
merged 1 commit into from Feb 8, 2023
Merged

Update addrmgr module #2206

merged 1 commit into from Feb 8, 2023

Conversation

jrick
Copy link
Member

@jrick jrick commented Feb 8, 2023

This provides performance improvements under SPV mode when few quality peers are available to return.

This provides performance improvements under SPV mode when few quality
peers are available to return.
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although in dex we're still gonna be using the pseudo version at v2.0.10-0.20230206141716-f9452d346121
Worth making a backport and proper v2.0.10 tag?

@jrick
Copy link
Member Author

jrick commented Feb 8, 2023

@chappjc you control the deps there so any wallet requires can be pushed ahead.

(unless you're talking about this working with a standalone release binary, i suppose)

@jrick jrick merged commit b9ba7c4 into decred:master Feb 8, 2023
@jrick jrick deleted the addrmgr branch February 8, 2023 16:54
@chappjc
Copy link
Member

chappjc commented Feb 8, 2023

I was partly alluding to the deadlock fix in the wallet code

@jrick
Copy link
Member Author

jrick commented Feb 8, 2023

Ah, understood. Sure we can do that.

Only fair to give you a proper wallet tag now, since I waited in wallet for the addrmgr tag before updating :)

@jrick jrick mentioned this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants