multi: Select unmanaged tickets outside VSP client #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the logic to select unmanaged tickets from the wallet database up into the wallet code. No need for this to be done in the VSP client. This also saves on database access by running ForUnspentUnexpiredTickets only once.
|
i realize that the grpc server is the only caller of this method right now, but will that always be the case? if we are going to move this logic around, i feel it makes more sense to move the unmanaged tickets selection code to a new method in the wallet package, so that e.g. the jsonrpc server could also call it. |
jrick
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the logic to select unmanaged tickets from the wallet database up into the wallet code. No need for this to be done in the VSP client.
This also saves on database access by running ForUnspentUnexpiredTickets only once.