Setup a signal context and use it. #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
Sep 9, 2023
jholdstock
reviewed
Sep 11, 2023
| // Use of this source code is governed by an ISC | ||
| // license that can be found in the LICENSE file. | ||
| // | ||
| //go:build windows || aix || android || darwin || dragonfly || freebsd || hurd || illumos || ios || linux || netbsd || openbsd || solaris |
There was a problem hiding this comment.
I don't think Windows should be on this list, it doesnt have SIGTERM afaik. Just os.Interrupt should suffice.
There was a problem hiding this comment.
SIGTERM is listed here: https://pkg.go.dev/syscall?GOOS=windows#pkg-constants
There was a problem hiding this comment.
It's correct and necessary to handle shutdown events from Windows correctly (namely CTRL_CLOSE_EVENT, CTRL_LOGOFF_EVENT and CTRL_SHUTDOWN_EVENT). Go added it a while back.
It's documented in the os/signal Windows section.
There was a problem hiding this comment.
I looked. It was added in Go 1.14. See the Minor changes to the library -> os/signal in the release notes.
davecgh
approved these changes
Sep 11, 2023
matheusd
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.