Chore improvements #379
Merged
Chore improvements #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tiagoalvesdulce
commented
Nov 12, 2021
•
tiagoalvesdulce
commented
- Upgrade old deps
- Make lint and prettier rules similar to politeiagui
- Remove pre-commit scripts
- Update react and react-dom peerDependencies to allow only react versions with hooks implemented (>16.8.0)
- Fix the code to pass new lint and prettify rules
- Remove node 15 from github workflow because it's unsupported. Our dependencies are not ready for node 16 yet so I added node 12. We are now building on node 12 and node 14. From node.js docs:
…mated fix commands
… react with hooks
bgptr
approved these changes
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.