multi: Add billing statuses. #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amass01
commented
Aug 5, 2021
amass01
commented
Aug 5, 2021
lukebp
requested changes
Aug 5, 2021
|
@lukebp Thanks for your valuable review, updated. |
amass01
commented
Aug 6, 2021
amass01
commented
Aug 6, 2021
setting billing status
amass01
changed the title
lukebp
requested changes
Aug 7, 2021
lukebp
requested changes
Aug 9, 2021
lukebp
requested changes
Aug 9, 2021
lukebp
requested changes
Aug 9, 2021
lukebp
reviewed
Aug 9, 2021
lukebp
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
tACK
A test case for the vote status verification and the success test case were left off because a testing framework has not been added yet for backend calls. I'm working on this. We can go back and fill in these two tests once I've added it. Test cases for all other validation are included in this PR.
This cannot be merged until the v1.1.0 release has been cut.
marcopeereboom
approved these changes
Aug 9, 2021
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff adds billing statuses to
polteiad'spiplugin and topoliteiawww'spiapi.Admins are able to set a billing status of an approved proposal using
the new
pictlcommand:proposalsetbillingstatus "token" "status" "reason"Note: reason is required only when setting record's billing status
to
closed.Currently, It's allowed to set a billing status only once.
Closes #1474.