politeiawww: Add websockets package. #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff moves the websocket code out of main and into a `websockets` package. A `Manager` context is used to manage the websocket connections instead of of having them stored directly on the politeiawww context. Packaging the websocket code like this will make it easier to move the websocket connections into a data store that allows for horizontal scaling of the politeiawww servers and will allow us to add a websocket plugin framework at some point in the future.
marcopeereboom
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff moves the websocket code out of main and into a
websocketspackage. A
Managercontext is used to manage the websocket connectionsinstead of of having them stored directly on the politeiawww context.
Packaging the websocket code like this will make it easier to move the
websocket connections into a data store that allows for horizontal
scaling of the politeiawww servers and will allow us to add a websocket
plugin framework at some point in the future.
This does not change any code. It's only re-organizing it.