Implement voting sortition in bunches #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code flips differential time tickers to N go routines that expire after some pre-determined time. We are moving to this model because differential time tickers have proven brittle. When a differential ticker does not fire everything else gets hung behind it but with this model an individual hang will not impact subsequent votes. The rough implementation is: * Votes are equally divided into bunches * Every bunch has a random start time and random duration * Votes fire after bunch start + random duration - If the vote fails it is retried in the same loop shortly after the failure - If the vote succeeds the go routine shuts down
marcopeereboom
force-pushed
the
votingworkers
branch
from
dcb3b14
to
10b4c86
Compare
marcopeereboom
force-pushed
the
votingworkers
branch
from
93eb6c4
to
dc4f832
Compare
lukebp
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code flips differential time tickers to N go routines that expire
after some pre-determined time. We are moving to this model because
differential time tickers have proven brittle. When a differential
ticker does not fire everything else gets hung behind it but with this
model an individual hang will not impact subsequent votes.
The rough implementation is: