politeiavoter: Fix retry loop bug. #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug that was preventing the failed vote retry loop from exiting when a SIGINT (ctrl+c) is received. The user was being forced to use a SIGKILL to kill the politeiavoter process. The root cause was that the retry loop was using a time.Sleep() call instead of using the WaitFor() call, which accepts a context and exits when the context is canceled.
marcopeereboom
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug that was preventing the failed vote retry loop
from exiting when a SIGINT (ctrl+c) is received. The user was being
forced to use a SIGKILL to kill the politeiavoter process.
The root cause was that the retry loop was using a time.Sleep() call
instead of using the WaitFor() call, which accepts a context and exits
when the context is canceled.
Introduced by #1556.
Closes #1590.