politeiavoter: Improve summary printing. #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the summary printing to consider already voted errors as being successfully cast votes. Already voted errors are not considered to be failures because they occur when a network error or dropped client connection causes politeiavoter to incorrectly think that the first attempt to cast the vote failed. politeiavoter will attempt to retry the vote that it has already successfully cast, resulting in the already voted error. Printing these errors as failures is misleading to the user, who will likely consider a failure as meaning the vote was not successfully cast, which is incorrect in this case.
marcopeereboom
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the summary printing to consider already voted
errors as being successfully cast votes.
Already voted errors are not considered to be failures because they
occur when a network error or dropped client connection causes
politeiavoter to incorrectly think that the first attempt to cast the
vote failed. politeiavoter will attempt to retry the vote that it has
already successfully cast, resulting in the already voted error.
Printing these errors as failures is misleading to the user, who will
likely consider a failure as meaning the vote was not successfully cast,
which is incorrect in this case.