sessions/mysql: Del expired sessions on startup. #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds code to the sessions database that deletes all expired sessions from the database on startup. The session store does not delete expired sessions from the database automatically. The gorilla/sessions API does not allow the session ID to be retrieved from a session cookie once the session has expired, so there is no way for the session store to know what IDs needs to be deleted from the database. The database layer must track when the session was created and manually delete expired sessions. This commit also removes the session database tests. They were poorly written and, in some cases, weren't actually testing what they thought they were. I have a seperate commit that rewrites the tests from scratch. I split the commits up because the diff easier to read.
lukebp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds code to the sessions database that deletes all expired
sessions from the database on startup.
The session store does not delete expired sessions from the database
automatically. The gorilla/sessions API does not allow the session ID to
be retrieved from a session cookie once the session has expired, so
there is no way for the session store to know what IDs needs to be
deleted from the database. The database layer must track when the
session was created and manually delete expired sessions.
This commit also removes the session database tests. They were poorly
written and, in some cases, weren't actually testing what they thought
they were. I have a seperate commit that rewrites the tests from
scratch. I split the commits up because the diff easier to read.