Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Information Propagation in Bitcoin Network" under Networks #13

Closed
wants to merge 1 commit into from

Conversation

AkashSarda
Copy link

Added a good paper on low level aspects of implementation of blockchains.
It is a good paper talking about propagation delay and is instrumental to anyone researching on Blockchain Scaling.

@cnasikas
Copy link
Member

Thanks! Please change commit messages to use the imperative and fix broken URL.

@AkashSarda
Copy link
Author

Done.

@cnasikas
Copy link
Member

cnasikas commented Nov 29, 2017

Thanks a lot! Please squash your commits into one and change the word Added to Add of the commit message.

@AkashSarda
Copy link
Author

Done.

@cnasikas
Copy link
Member

Great! Sorry to bother again but each pull request should be one clean commit with all suggested changes. Please squash them into one with all changes included.

Also please change Decker, C., Wattenhofer, R. IEEE P2P. (2013) to Decker C, Wattenhofer R. IEEE P2P '13.

@AkashSarda
Copy link
Author

AkashSarda commented Nov 29, 2017 via email

@AkashSarda
Copy link
Author

AkashSarda commented Nov 29, 2017 via email

@AkashSarda
Copy link
Author

Look it up. Done.

@cnasikas
Copy link
Member

cnasikas commented Nov 29, 2017

Perfect! Please change the citation from Decker, C., Wattenhofer, R. IEEE P2P. (2013) to Decker C, Wattenhofer R. IEEE P2P '13. and is ready to be accepted.

I took the citation from a published paper so it should not be a problem.

I understand but if you see we follow a standard formatting and yours deviates from it.

@AkashSarda
Copy link
Author

AkashSarda commented Nov 29, 2017 via email

@cnasikas
Copy link
Member

Thanks a lot but I don't see any citation changes. The commit is perfect, one and clean. Only the citation needs to be changed.

@cnasikas cnasikas closed this Nov 1, 2018
@dionyziz
Copy link
Member

dionyziz commented Nov 1, 2018

Fixed and added in 9687267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants