Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 5.0 Support #19

Closed
glassipbel opened this issue Jul 18, 2019 · 6 comments
Closed

Swift 5.0 Support #19

glassipbel opened this issue Jul 18, 2019 · 6 comments
Labels

Comments

@glassipbel
Copy link
Contributor

Can you update the library to Swift 5.0?

Let me know if you need help i could create PR and do it myself :)

@Decybel07
Copy link
Owner

Decybel07 commented Jul 19, 2019

I think I support all versions above swift 3. It’s possible that I forgot about something then please create PR but remember to keep compatibility with previous versions

@glassipbel
Copy link
Contributor Author

glassipbel commented Jul 19, 2019

Hi there :)
Thanks for the response,
Regarding compatibility you mean about xcode compatiblity?
or IOS compatibility?
Because if it’s xcode we should push this version to 5.0 and the people that have their projects in older versions, they should use another branch/commit.
So what i can do is basically update all the methods and the entire project basically to swift 5.0 and regarding the iOS systems i can leave them as it is right now.

Would that be okay for you? If so i will do that tomorrow :)

@Decybel07
Copy link
Owner

I mean compatibility with previous versions of swift.

@glassipbel
Copy link
Contributor Author

Hi there i saw that you merged it, can you publish that change to cocoapods? i'm trying to pod update but i don't see the changes yet.
Thanks and sorry for the troubles.

@Decybel07
Copy link
Owner

I have just published a new version. I had to make some changes to publish this version

@glassipbel
Copy link
Contributor Author

@Decybel07 Thank you so much for the quick response and for this amazing library :)
Have a great weekend!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants