module.exports['browser'] <-- typo?

[ibc]

!function (name, definition) {
  if (typeof module != 'undefined' && module.exports) module.exports['browser'] = definition()
  else if (typeof define == 'function' && define.amd) define(definition)
  else this[name] = definition()
}('bowser', function () {

May be it should be module.exports['bowser']?

[ibc]

Why module.exports[ANYTHING]? Currently when I use this library in a Node project that is finally bundled using "browserify", I need to do this to use its API:

var bowser = require('bowser');

if (bowser.browser.chrome) { ... }

Instead, if I load the library in the old way (<script src='js/bowser.js'></script>) then I should use:

if (bowser.chrome) { ... }

I'll send a PR to fix it.

[ibc]

OK, thanks.

[ded]

there's no right or wrong answer to this. we'd have to bump it to a major version, which is fine...

[ibc]

OK, note that it would be more consistent (same behavior and API for both browser and Node).
Thanks.

[vvo]

10 minutes wasted because of this. What do we do?

[ibc]

var bowser = require('bowser') should export the bowser module, instead of an Object with a field called browser or bowser, so its API would be consistent regardless the library is used as a standalone <script> tag or as a AMD/CommonJS module.

[vvo]

fixed this @ded

[ded]

hey all — this has been fixed in the 1.0.0 version. Thus require('bowser') will work the same as it does in Node.js 👍