gRPC implementation for Mino - Handler.Process #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkcr
changed the title
Gilthoniel
reviewed
Mar 5, 2020
Gilthoniel
reviewed
Mar 6, 2020
mino/minogrpc/overlay.go
Outdated
| return nil, xerrors.Errorf("header not found in provided context") | ||
| } | ||
|
|
||
| apiURI, ok := headers["apiuri"] |
There was a problem hiding this comment.
Can you add a constant for that string ?
mino/minogrpc/server.go
Outdated
| SerialNumber: big.NewInt(1), | ||
| IPAddresses: []net.IP{net.ParseIP("127.0.0.1")}, | ||
| NotBefore: time.Now(), | ||
| NotAfter: time.Now().Add(time.Hour * 24 * 180), |
Gilthoniel
approved these changes
Mar 6, 2020
bbjubjub2494
pushed a commit
to bbjubjub2494/dela
that referenced
this pull request
Aug 3, 2024
gRPC implementation for Mino - Handler.Process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step that only implements the simple Handler.Process
This is far from perfect and there are still untested edge cases, but that would be good to do an early review.