Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets a custom check for comments length #35

Merged
merged 35 commits into from
Apr 8, 2020
Merged

Sets a custom check for comments length #35

merged 35 commits into from
Apr 8, 2020

Conversation

nkcr
Copy link
Contributor

@nkcr nkcr commented Apr 7, 2020

No description provided.

@nkcr nkcr added the enhancement New feature or request label Apr 7, 2020
@nkcr nkcr self-assigned this Apr 7, 2020
nkcr added 21 commits April 7, 2020 16:46
@nkcr
Refactors the code and ignores generated files
80c2663
@nkcr
Updates wrong line length
c9980dc
@nkcr
Adds tests
7813c7b
@nkcr
Updates the Makefile
d6c904d
@nkcr
Updates the Makefile
2b3d3d1
@nkcr
Updates go.mod
01b42fa
@nkcr
Comments static check
64e745e
@nkcr
Comments the new check
e10fb2a
@nkcr
Re-adds the custom check
bcbdfc7
@nkcr
Adds a new make command to vet
3d0f153
@nkcr
Renames the "check" program to avoid conflicts
7a8d4c0
@nkcr
Uses an absolute path to fabricCheck
495e704
@nkcr
Updates the makefile
49a676c
@nkcr
Re updates the Makefile
b41d670
@nkcr
Reverts past refactoring
7960d7b 
In the hope travis will be happy
@nkcr
Revert "Reverts past refactoring"
3444f07 
This reverts commit 7960d7b.
@nkcr
Updates the Makefile
d8cf1aa
@nkcr
Updates the travis.yml
16bf96c
@nkcr
Revert "Updates the travis.yml"
7bed60a 
This reverts commit 16bf96c.
@nkcr
Updates travis to use go 1.14
82da445
@nkcr
Adds case to ignore go:generate comment
a74ad28
@nkcr nkcr added the R4M 🚀 The PR is ready to be reviewed and merged label Apr 8, 2020
@nkcr nkcr requested a review from Gilthoniel April 8, 2020 07:19
Gilthoniel
Gilthoniel reviewed Apr 8, 2020
View reviewed changes
Copy link
Contributor

@Gilthoniel Gilthoniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool ! We might use it to check the comment guidelines ;)

Makefile Show resolved Hide resolved
internal/mcheck/mod_test.go Outdated Show resolved Hide resolved
@Gilthoniel Gilthoniel merged commit 9e0351f into master Apr 8, 2020
@Gilthoniel Gilthoniel deleted the comment-check branch April 8, 2020 14:57
bbjubjub2494 pushed a commit to bbjubjub2494/dela that referenced this pull request Aug 3, 2024
@nkcr
Sets a custom check for comments length (dedis#35)
4a4ff1b 
This add a custom check for comments length and initialization in if statements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gilthoniel Gilthoniel Gilthoniel approved these changes

Assignees

@nkcr nkcr

Labels
enhancement New feature or request R4M 🚀 The PR is ready to be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nkcr @Gilthoniel