Consensus module #5
Conversation
| uint32 height = 2; | ||
| uint32 baseHeight = 3; | ||
| uint32 maximumHeight = 4; | ||
| bytes genesisID = 5; |
There was a problem hiding this comment.
what does represent the genesisID?
There was a problem hiding this comment.
That's the hash of the genesis block which is used as the chain identifier.
consensus/cosipbft/forward_link.go
Outdated
| DecodeForwardLink(pb proto.Message) (forwardLink, error) | ||
| } | ||
|
|
||
| // defaultChainFactory is an implementation of the defaultChainFactory interface for forward links. |
There was a problem hiding this comment.
| // defaultChainFactory is an implementation of the defaultChainFactory interface for forward links. | |
| // defaultChainFactory is an implementation of the defaultChainFactory interface | |
| // for forward links. |
cosi/mod.go
Outdated
| // Hashable is the interface to implement to validate an incoming message | ||
| // for a collective signing. It will return the hash that will be signed. |
There was a problem hiding this comment.
| // Hashable is the interface to implement to validate an incoming message | |
| // for a collective signing. It will return the hash that will be signed. | |
| // Hashable is the interface to implement to validate an incoming message for a | |
| // collective signing. It will return the hash that will be signed. |
mino/minoch/address.go
Outdated
| // AddressFactory is an implementation of the factory interface. | ||
| type AddressFactory struct{} | ||
|
|
||
| // FromText returns an instance of an address from a string. |
There was a problem hiding this comment.
| // FromText returns an instance of an address from a string. | |
| // FromText returns an instance of an address from a byte slice. |
consensus/cosipbft/mod.go
Outdated
| rpcName = "cosipbft" | ||
| ) | ||
|
|
||
| // Consensus is the implementation of the interface. |
There was a problem hiding this comment.
| // Consensus is the implementation of the interface. | |
| // Consensus is the implementation of the consensus.Consensus interface. |
consensus/cosipbft/mod.go
Outdated
| return nil, encoding.NewAnyDecodingError(&da, err) | ||
| } | ||
|
|
||
| // The proposal first need to be validated by the caller of the module |
There was a problem hiding this comment.
| // The proposal first need to be validated by the caller of the module | |
| // The proposal first needs to be validated by the caller of the module |
|
|
||
| // LockProposal verifies the prepare signature and stores it. It also locks | ||
| // the queue to prevent further committing. | ||
| func (q *queue) LockProposal(to Digest, sig crypto.Signature) error { |
There was a problem hiding this comment.
what if q.locked is already true ?
There was a problem hiding this comment.
Yes, you're right !
consensus/cosipbft/storage.go
Outdated
| // ReadChain returns the list of forward links to the id. It returns an error | ||
| // if the target is never reached. |
There was a problem hiding this comment.
| // ReadChain returns the list of forward links to the id. It returns an error | |
| // if the target is never reached. | |
| // ReadChain returns the list of forward links to the id (which is not | |
| // included). It returns an error if the target is never reached. |
There was a problem hiding this comment.
Hm it is actually included in the last forward link which has to point on id.
| // Validate should return the proposal decoded from the message or | ||
| // an error if it is invalid. It should also return the previous | ||
| // proposal. | ||
| Validate(message proto.Message) (curr Proposal, prev Proposal, err error) |
There was a problem hiding this comment.
that feels very tight to the way we make verification now, but we could imagine scenarios where a validation needs something else. What if we make the consensus use on the blockchain abstraction?
That would give something like:
Validate(message proto.Message) (bc Blockchain, blockIndex int, err error)
There was a problem hiding this comment.
My point was to build blockchain on top of the consensus but this one should not be aware of what is a blockchain. You could totally build something on top of the consensus that is unrelated to blockchain. The benefit is that the module is responsible to create the crypto links between proposals but a proposal can be anything.
|
@nkcr thanks for the comments! I answered some of them, if you can have a second look. |
This extracts the logic of the consensus from the skipchain module and implements the collective signing PBFT from the byzcoin paper.
Note: skipchain to improve later.