Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more test coverage #70

Closed
KingAkeem opened this issue Feb 25, 2018 · 7 comments
Closed

Add more test coverage #70

KingAkeem opened this issue Feb 25, 2018 · 7 comments
Labels
Good First Issue Hacktoberfest HackToberFest 2023 Help Wanted Unit test

Comments

@KingAkeem
Copy link
Member

KingAkeem commented Feb 25, 2018 •
edited

We should add more checks to each test case to cover cases more thoroughly. We should add coverage for edge cases, unexpected input and etc.

This is being addressed with #95 but we still need more test for network utilities and we should still cover more test cases.
@mamarto
Copy link
Contributor

mamarto commented Feb 26, 2018

Yes, I was thinking the same thing to be honest.

@PSNAppz
Copy link
Member

PSNAppz commented Mar 14, 2018

I agree .

@PSNAppz PSNAppz added this to the TorBot v1.3 milestone Jul 8, 2018
@KingAkeem KingAkeem mentioned this issue Aug 8, 2018
Merged
@PSNAppz
Copy link
Member

PSNAppz commented Aug 16, 2018 •
edited

Not closing this until coverage is at least 80%

@KingAkeem KingAkeem assigned KingAkeem and unassigned KingAkeem Aug 19, 2018
@KingAkeem
Copy link
Member Author

@shivankar-madaan is currently working on this.

@PSNAppz PSNAppz added the Hacktoberfest HackToberFest 2023 label Sep 14, 2018
@PSNAppz PSNAppz removed this from the TorBot v1.3 milestone Oct 28, 2018
@KingAkeem
Copy link
Member Author

This is no longer being worked on if anyone wants to take a look.

@KingAkeem
Copy link
Member Author

This can be broken up into a couple of tasks.

  1. Decide on testing framework
  2. Decide on HTTP client mocking library or create custom mocks
  3. Design necessary mocks and write unit tests

@KingAkeem KingAkeem removed Hacktoberfest HackToberFest 2023 Med Priority labels Jun 10, 2021
@PSNAppz PSNAppz added the Hacktoberfest HackToberFest 2023 label Sep 21, 2021
@KingAkeem
Copy link
Member Author

Majority of crawling logic has been moved to https://github.com/KingAkeem/gotor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Hacktoberfest HackToberFest 2023 Help Wanted Unit test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PSNAppz @mamarto @KingAkeem