Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output_layer_id should be required in the fit instead of instanciation of ood detector #68

Closed
y-prudent opened this issue Aug 25, 2023 · 0 comments · Fixed by #72
Closed

Comments

@y-prudent
Copy link
Member

y-prudent commented Aug 25, 2023

Before:

dknn = DKNN(output_layer_id=[-2])
dknn.fit(model, ds_fit)

After:

dknn = DKNN()
dknn.fit(model, ds_fit, output_layer_id=[-2])

[Update]
Also, for improved clarity output_layers_id should be renamed feature_layers_id. The feature extractor would then return separately in a tuple: (1) the features (identified by feature_layers_id) and (2) the logits (output of last layer).

After v2:

dknn = DKNN()
dknn.fit(model, ds_fit, feature_layers_id=[-2])
@paulnovello paulnovello linked a pull request Sep 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant