Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature attribution: singleton pattern as class attribute instead of inheritance #15

Closed
fel-thomas opened this issue Apr 26, 2021 · 0 comments
Closed

feature attribution: singleton pattern as class attribute instead of inheritance #15

fel-thomas opened this issue Apr 26, 2021 · 0 comments
Assignees
@fel-thomas
Labels
feature-attribution New feature or issue concerning Attribution methods refactor Improvements relative to existing code
Projects
Roadmap

Comments

@fel-thomas
Copy link
Member

Some methods share large portions of code. A first implementation uses inheritance to override static methods to fit the specificity. A better solution is to pass a tf.function static singleton as parameter.
@fel-thomas fel-thomas created this issue from a note in Roadmap (April-June) Apr 26, 2021
@fel-thomas fel-thomas self-assigned this Apr 26, 2021
@fel-thomas fel-thomas added feature-attribution New feature or issue concerning Attribution methods refactor Improvements relative to existing code labels Apr 26, 2021
@lucashervier lucashervier mentioned this issue Jun 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fel-thomas fel-thomas

Labels
feature-attribution New feature or issue concerning Attribution methods refactor Improvements relative to existing code
Projects
Roadmap
March - August 2022
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fel-thomas