Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Response confirmation email #44

Closed
avishkar58 opened this issue Feb 7, 2019 · 7 comments
Closed

Implement Response confirmation email #44

avishkar58 opened this issue Feb 7, 2019 · 7 comments
Assignees
Labels
back-end Back-end work enhancement New feature or request

Comments

@avishkar58
Copy link
Contributor

Depends on #43

Send a confirmation email when the user submits their response.
This should be implemented in the POST method of the response API in app/api/responses/api.py and is triggered when the "is_submitted" flag is set to true in the request data. The email should be sent using api/app/utils/emailer.py. The email should be worded as follows (replace anything in angle brackets {} with the appropriate data)

Dear {User.title} {User.firstname} {User.lastname},

Thank you for applying to attend {Event.description}. Your application is being reviewed by our committee and we will get back to you as soon as possible. Included below is a copy of your responses.

{INSERT SUMMARY OF ANSWERS TO THE QUESTIONS IN THE RESPONSE}

Kind Regards,
The {Event.name} Organising Committee

Definition of Done
This task is done when

  • The POST method in api/app/response/api.py has been updated to create the email message
  • The emailer service is called to send the email
  • A unit test exists for this functionality which mocks out the email service.
@avishkar58 avishkar58 added enhancement New feature or request back-end Back-end work labels Feb 9, 2019
@avishkar58 avishkar58 added this to To do in Baobab Iteration 1 Feb 13, 2019
@avishkar58
Copy link
Contributor Author

Response Controller has been implemented, so this is ready for someone to pick up

@Carvalho96v2 Carvalho96v2 self-assigned this Feb 15, 2019
@Carvalho96v2
Copy link
Collaborator

I can jump on this

@Carvalho96v2
Copy link
Collaborator

Hey @avishkar58 , sorry this has taken so long, I've been pretty busy these past few days, looking at this now.

With regards to the unit test, because we're baking this into the post method, wouldn't the existing post method's unit test cover this too? Or would the unit test just cover the content and formatting of the email?

@avishkar58
Copy link
Contributor Author

avishkar58 commented Feb 20, 2019 via email

@Carvalho96v2
Copy link
Collaborator

Okay cool, as of right now though we've only got filler data (SMTP host, ports, etc) for the emailer service, so emails don't send at all. Is this correct as is?

@avishkar58
Copy link
Contributor Author

avishkar58 commented Feb 20, 2019 via email

@Carvalho96v2
Copy link
Collaborator

Okay sweet, yeah that sounds good

@avishkar58 avishkar58 moved this from To do to Done in Baobab Iteration 1 Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Back-end work enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants