-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Response confirmation email #44
Comments
Response Controller has been implemented, so this is ready for someone to pick up |
I can jump on this |
Hey @avishkar58 , sorry this has taken so long, I've been pretty busy these past few days, looking at this now. With regards to the unit test, because we're baking this into the post method, wouldn't the existing post method's unit test cover this too? Or would the unit test just cover the content and formatting of the email? |
Hey, yes the existing POST unit test should be fine, but you might need to
mock out the email service since we don't want to send emails from tests..
…On Wed, 20 Feb 2019 at 15:38 Jean-vicente De Carvalho < ***@***.***> wrote:
Hey @avishkar58 <https://github.com/avishkar58> , sorry this has taken so
long, I've been pretty busy these past few days, looking at this now.
With regards to the unit test, because we're baking this into the post
method, wouldn't the existing post method's unit test cover this too? Or
would the unit test just cover the content and formatting of the email?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEte7HoC0YvEQc1QQdJuTgKzRiDw0vzyks5vPWvagaJpZM4aqTcF>
.
|
Okay cool, as of right now though we've only got filler data (SMTP host, ports, etc) for the emailer service, so emails don't send at all. Is this correct as is? |
Yeah that's correct for now, the correct values get filled in between
CircleCI and GCP I believe - there's some on-going discussion around how to
do this for development - maybe we just use a mock service for development
too which writes to STDOUT or something?
…On Wed, 20 Feb 2019 at 15:42 Jean-vicente De Carvalho < ***@***.***> wrote:
Okay cool, as of right now though we've only got filler data (SMTP host,
ports, etc) for the emailer service, so emails don't send at all. Is this
correct as is?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEte7H92mR-rQg2Ho_zlnvzgN1_L6WBtks5vPWzrgaJpZM4aqTcF>
.
|
Okay sweet, yeah that sounds good |
Depends on #43
Send a confirmation email when the user submits their response.
This should be implemented in the POST method of the response API in app/api/responses/api.py and is triggered when the "is_submitted" flag is set to true in the request data. The email should be sent using api/app/utils/emailer.py. The email should be worded as follows (replace anything in angle brackets {} with the appropriate data)
Definition of Done
This task is done when
The text was updated successfully, but these errors were encountered: