Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release patch 1.0.1 with torch install_requires fix #26

Closed
tgaddair opened this issue Mar 1, 2022 · 5 comments
Closed

Release patch 1.0.1 with torch install_requires fix #26

tgaddair opened this issue Mar 1, 2022 · 5 comments

Comments

@tgaddair
Copy link

tgaddair commented Mar 1, 2022

Thanks for creating this useful library. We recently included it as part of our low code toolkit, Ludwig. However, we ran into an issue whereby if the user does not have torch already installed before installing entmax, it raises an exception:

× python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [10 lines of output]
      Traceback (most recent call last):
        File "<string>", line 36, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-xasbhx2w/entmax_64da4068d2414a04a5c3adc7187695b4/setup.py", line 2, in <module>
          from entmax import __version__
        File "/tmp/pip-install-xasbhx2w/entmax_64da4068d2414a04a5c3adc7187695b4/entmax/__init__.py", line 3, in <module>
          from entmax.activations import sparsemax, entmax15, Sparsemax, Entmax15
        File "/tmp/pip-install-xasbhx2w/entmax_64da4068d2414a04a5c3adc7187695b4/entmax/activations.py", line 13, in <module>
          import torch
      ModuleNotFoundError: No module named 'torch'
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

Looks like this was fixed some time back here, but this change was made after the v1.0 release, meaning the current production release has this bug. Can you create a patch release v1.0.1 that includes this fix?

Thanks.

@bpopeters
Copy link
Collaborator

Hello,

I'll try to take care of this before the end of the week. Thank you for your interest!

@cifkao
Copy link

cifkao commented Mar 29, 2022

I would also very much appreciate this! I'm depending on a package which depends on entmax and this issue is unfortunately breaking my setup.

@cifkao
Copy link

cifkao commented Mar 30, 2022

Actually, this does not really fix the issue. #27 or #25 (which I noticed only after submitting #27) does. @bpopeters Would you please consider merging one of these PRs and releasing a patch?

@lukas-blecher
Copy link

lukas-blecher commented May 24, 2022

@bpopeters (or @vene) please merge one of the above and release a new version.

@bpopeters
Copy link
Collaborator

Fixed via #25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants