encode 0 with a max of 0 with all encoding types

deepakjois · Mar 5, 2010 · 412b6cb · 412b6cb
1 parent 248fd24
commit 412b6cb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/lib/google_chart.rb b/lib/google_chart.rb
@@ -24,10 +24,10 @@ def encode(encoding, n, max)
       case encoding
       when :simple
         return "_" if n.nil?
-        SIMPLE_CHARS[((n/max.to_f) * (SIMPLE_CHARS.size - 1)).round]
+        SIMPLE_CHARS[((n.zero? ? 0 : n/max.to_f) * (SIMPLE_CHARS.size - 1)).round]
       when :text
         return "-1" if n.nil?
-        ((((n/max.to_f) * 1000.0).round)/10.0).to_s
+        ((((n.zero? ? 0 : n/max.to_f) * 1000.0).round)/10.0).to_s
       when :extended
         return "__" if n.nil?
         EXTENDED_PAIRS[max.zero? ? 0 : ((n/max.to_f) * (EXTENDED_PAIRS.size - 1)).round]

diff --git a/spec/gchartrb_spec.rb b/spec/gchartrb_spec.rb
@@ -111,7 +111,15 @@ class <<self ; public :new ; end
     GoogleChart.encode(:extended, nil, 1).should == "__"
   end
 
-  it "encodes 0 with a max of 0 correctly" do
+  it "encodes 0 with a max of 0 correctly using extended" do
     GoogleChart.encode(:extended, 0, 0).should == "AA"
   end
+
+  it "encodes 0 with a max of 0 correctly using simple" do
+    GoogleChart.encode(:simple, 0, 0).should == "A"
+  end
+
+  it "encodes 0 with a max of 0 correctly using text" do
+    GoogleChart.encode(:text, 0, 0).should == "0.0"
+  end
 end