Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrsimulator returns spectra with periodic dimensions #346

Closed
mccarthy677 opened this issue May 10, 2024 · 0 comments 路 Fixed by #348
Closed

Mrsimulator returns spectra with periodic dimensions #346

mccarthy677 opened this issue May 10, 2024 · 0 comments 路 Fixed by #348
Labels
bug Something isn't working

Comments

@mccarthy677
Copy link
Collaborator

Did you find a bug? Please help us improve by fill out the sections below. 馃憤

Describe the bug

mrsimulator is returning spectra with periodic dimensions, even though spectra shouldn't be periodic

To Reproduce

Steps to reproduce the behavior:

from mrsimulator import Simulator, SpinSystem, Site
from mrsimulator.method.lib import BlochDecaySpectrum
import matplotlib.pyplot as plt

H_site = Site(isotope="1H", shielding_symmetric={"zeta": 13.89, "eta": 0.25})
spin_system = SpinSystem(sites=[H_site])

static = BlochDecaySpectrum(channels=["1H"])
mas = BlochDecaySpectrum(channels=["1H"], rotor_frequency=1000)  # in Hz

sim = Simulator(spin_systems=[spin_system], methods=[static, mas])
sim.run()

print(sim.methods[0].simulation.x[0].period)

returns 25000 Hz

Expected behavior

Would expect a period of infinity (this is what I get if I print the period of a csdf object with periodic unchecked in RMN)

Desktop (please complete the following information):

  • OS: Windows 11
  • Python version: 3.9.19
  • mrsimulator version: 0.8.0rc
@deepanshs deepanshs added the bug Something isn't working label May 19, 2024
@deepanshs deepanshs linked a pull request May 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants