Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dead Links as observed in the MarkDown Action. #69

Closed
vybhav72954 opened this issue Feb 28, 2021 · 17 comments
Closed

Remove Dead Links as observed in the MarkDown Action. #69

vybhav72954 opened this issue Feb 28, 2021 · 17 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@vybhav72954
Copy link
Collaborator

vybhav72954 commented Feb 28, 2021

We recently implemented a MarkDOwn Link checking action for this List.

The Link checker found various dead links. The report can be found here

These links should be removed but they should be checked once again for ensuring that the action is not doing any mistake.

@vybhav72954 vybhav72954 added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 28, 2021
@chiragbansal-45
Copy link
Contributor

I would like to take this issue.

@chiragbansal-45
Copy link
Contributor

chiragbansal-45 commented Mar 2, 2021

do you want me to check all the links or just for the dead links?

@vybhav72954
Copy link
Collaborator Author

vybhav72954 commented Mar 2, 2021

@chiragbansal-45 The dead links can be found here already

I want you to check, if the domains have shifted to somewhere else, there is a typo, or the programs are completely dead.

After that please comment here, and then you can open a PR regarding the same. I will assign this to you.

@chiragbansal-45
Copy link
Contributor

okay! got it

@chiragbansal-45
Copy link
Contributor

I have checked and did the necessary edits. but in doing so I have committed many times because of some error. so, what should I do now?

@vybhav72954
Copy link
Collaborator Author

Sorry i didn't get it.

In case you want to start fresh.

Rebase master, and make a new branch.

@vybhav72954
Copy link
Collaborator Author

I have checked and did the necessary edits. but in doing so I have committed many times because of some error. so, what should I do now?

I will have a look at your fork if I can figure out whats going on.

@chiragbansal-45
Copy link
Contributor

okay!

@chiragbansal-45
Copy link
Contributor

I have checked and did the necessary edits. but in doing so I have committed many times because of some error. so, what should I do now?

I will have a look at your fork if I can figure out whats going on.

yes, please

@vybhav72954
Copy link
Collaborator Author

I have checked and did the necessary edits. but in doing so I have committed many times because of some error. so, what should I do now?

I will have a look at your fork if I can figure out whats going on.

yes, please

A piece of advice for you. Generally, it's not recommended to make commits in the master or main branch of your fork.

You should make a new branch from the master using git checkout -b <name of new branch> (without the chevrons of course).
(-b is for making a new branch)
Then do your changes, do a git add and then git commit

Then push your changes using git push -u origin <name of new branch>

By following this workflow, you will notice that if in any case, you mess up something, you can again check out back to master using git checkout master and make a new branch.

In your case, we can do 2 things:

Either we Rebase the master branch (professional method).

Or we can make a new fork (It's a workaround, but is far easier).

If you know how to rebase, or you want to rebase, I can help you with that, or else you can delete the fork, and make a new PR.

@vybhav72954
Copy link
Collaborator Author

Or maybe you aren't using Comand Line Interface, is that true?

@chiragbansal-45
Copy link
Contributor

Or maybe you aren't using Comand Line Interface, is that true?

yes, I was not using CLI as I thought it can be done easily directly.
I think I should rebase the master branch and then create a new branch.
also, thank you for helping.

@chiragbansal-45
Copy link
Contributor

I tried to rebase by git rebase -i HEAD~10 , but it didn't work can you help me with doing rebase.

@vybhav72954
Copy link
Collaborator Author

You will have to set up an upstream using command.

git remote add upstream https://github.com/deepanshu1422/List-Of-Open-Source-Internships-Programs.git

The rebase your master with upstream.
Alternatively git pull --rebase upstream or git pull can provide the same result depending upon the working tree.

I would still recommend deleting your fork and making a new one though.

Adding an upstream is necessary because you have diverged origin/master with your 10 commits

@chiragbansal-45
Copy link
Contributor

okay, I will make a new fork then.

@chiragbansal-45
Copy link
Contributor

I did all the changes in a new branch. should I create a PR now?

@vybhav72954
Copy link
Collaborator Author

I did all the changes in a new branch. should I create a PR now?

Yes, please. Eagerly waiting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants